Adding scheduling decision CRD: "why/why" not api #307
+6,569
−225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblos
previously approved these changes
Sep 25, 2025
PhilippMatthes
commented
Oct 1, 2025
internal/scheduler/nova/pipeline.go
Outdated
|
|
||
| if err := c.Client.Update(context.Background(), &existing); err != nil { | ||
| // Check if it's a conflict error (concurrent update) | ||
| if attempt < maxRetries-1 { |
There was a problem hiding this comment.
Can this happen? I would have thought that the Update method is threadsafe and consistent with the state in kubernetes. Otherwise we should add a mutex, no?
There was a problem hiding this comment.
CRD schema treats spec and status as separated update, so should be fine if there is a single entity changing the spec. Simplified for now
There was a problem hiding this comment.
Thanks for checking that up!
mblos
changed the title
mblos
requested review from
auhlig,
umswmayj,
maxhof42 and
SoWieMarkus
as code owners
Test Coverage ReportCoverage in main module (internal/): 73.3%Coverage in reservations module (reservations/internal/): 74.6% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adds an api to cortex that describes why a virtual machine has been placed on a specific compute host. It exposes the raw pipeline weights with a kubernetes custom resource, and the associated operator calculates a human-readable description from the provided values. The resource is also connected to the nova visualizer so that decisions can be spectated in the browser removing this dependency on the mqtt broker.